From 62401d1f76b53d23c548be0445eec718f1436062 Mon Sep 17 00:00:00 2001
From: Sam Carlton <sam@sam.lc>
Date: Sat, 4 Jun 2022 19:49:36 -0500
Subject: [PATCH] Add support for updating existing filters

---
 helpers/stork/browser.js |  2 +-
 test/prebuild/filters.js | 15 +++++++++++++--
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/helpers/stork/browser.js b/helpers/stork/browser.js
index 7b096a1..b8b9a44 100644
--- a/helpers/stork/browser.js
+++ b/helpers/stork/browser.js
@@ -284,7 +284,7 @@ export class StorkFilters {
         filterValue = filterValue || fromString.value
 
         // If the filter is already set, remove it
-        if ( this.hasFilter( filterName ) ) {
+        if ( this.hasFilter( filterNameOrQueryValue ) ) {
             this.removeFilter( filterName )
 
             return
diff --git a/test/prebuild/filters.js b/test/prebuild/filters.js
index af12ccf..4f7d261 100644
--- a/test/prebuild/filters.js
+++ b/test/prebuild/filters.js
@@ -44,7 +44,18 @@ test('Can handle query values with multiple underscores', async t => {
     t.assert( filters.hasFilter( 'test_value_with_multiple_underscores' ) , 'Has correct filters for query' )
 })
 
-// Can handle query values with multiple underscores
+
+test( 'Can update existing filter', async t => {
+    const filters = new StorkFilters({
+        initialFilters: {
+            'test': 'works_no'
+        }
+    })
+
+    filters.toggleFilter('test_works_yes')
+
+    t.deepEqual( filters.filtersForQuery, 'test_works_yes', 'Has updated filter')
+})
+
 
 
-// Can update existing filter