Buck9195/doesitarm
1
0
Fork 0
mirror of https://github.com/ThatGuySam/doesitarm.git synced 2026-05-15 06:35:20 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Set filterSeparator as constant

Browse source
This commit is contained in:
Sam Carlton 2022-06-05 11:43:52 -05:00
parent 25708dccae
commit a801e96511
3 changed files with 10 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
helpers/constants.js Normal file
View file

@ -0,0 +1,2 @@
export const filterSeparator = '_'

8
helpers/statuses.js
View file

@ -1,4 +1,4 @@
import { filterSeparator } from '~/helpers/constants.js'
const statuses = { const statuses = {
@ -38,8 +38,6 @@ const statusesByIcon = Object.keys( statuses ).reduce( ( acc, key ) => {
export const statusFilterPrefix = 'status' export const statusFilterPrefix = 'status'
export const statusFilterSeparator = '_'
// Example: // Example:
// { // {
@ -48,11 +46,11 @@ export const statusFilterSeparator = '_'
// }, // },
export const defaultStatusFilters = Object.keys( statuses ).reduce( ( acc, key ) => { export const defaultStatusFilters = Object.keys( statuses ).reduce( ( acc, key ) => {
const status = statuses[ key ] const status = statuses[ key ]
acc[ statusFilterPrefix + statusFilterSeparator + key ] = status.filterLabel acc[ statusFilterPrefix + filterSeparator + key ] = status.filterLabel
acc = [...acc, { acc = [...acc, {
label: `${ status.icon } ${ status.filterLabel }`, label: `${ status.icon } ${ status.filterLabel }`,
query: statusFilterPrefix + statusFilterSeparator + status.snakeSlug query: statusFilterPrefix + filterSeparator + status.snakeSlug
}] }]
return acc return acc
}, [] ) }, [] )

13
helpers/stork/browser.js
View file

@ -1,3 +1,4 @@
import { filterSeparator } from '~/helpers/constants.js'
import { isString } from '~/helpers/check-types.js' import { isString } from '~/helpers/check-types.js'
@ -6,7 +7,6 @@ import {
storkScriptURL storkScriptURL
} from '~/helpers/stork/config.js' } from '~/helpers/stork/config.js'
export function makeHighlightedMarkup ( options = {} ) { export function makeHighlightedMarkup ( options = {} ) {
const { const {
text, text,
@ -227,9 +227,6 @@ export class StorkClient {
} }
} }
const statusFilterSeparator = '_'
export class StorkFilters { export class StorkFilters {
constructor({ constructor({
initialFilters = {} initialFilters = {}
@ -243,7 +240,7 @@ export class StorkFilters {
get list () { get list () {
return Object.entries( this.filters ).map( ([ filterKey, filterValue ]) => { return Object.entries( this.filters ).map( ([ filterKey, filterValue ]) => {
return `${ filterKey }${ statusFilterSeparator }${ filterValue }` return `${ filterKey }${ filterSeparator }${ filterValue }`
} ) } )
} }
@ -252,12 +249,12 @@ export class StorkFilters {
} }
isQueryValue ( filterNameOrQueryValue ) { isQueryValue ( filterNameOrQueryValue ) {
return filterNameOrQueryValue.includes( statusFilterSeparator ) return filterNameOrQueryValue.includes( filterSeparator )
} }
getKeyAndValue ( filterQueryValue ) { getKeyAndValue ( filterQueryValue ) {
const key = filterQueryValue.substring(0, filterQueryValue.indexOf( statusFilterSeparator )) const key = filterQueryValue.substring(0, filterQueryValue.indexOf( filterSeparator ))
const value = filterQueryValue.substring(filterQueryValue.indexOf( statusFilterSeparator )+1) const value = filterQueryValue.substring(filterQueryValue.indexOf( filterSeparator )+1)
return { key, value } return { key, value }
} }