From b28303305ea99a50a54529b7f10171b15751da4b Mon Sep 17 00:00:00 2001
From: Sam Carlton <sam@sam.lc>
Date: Mon, 29 Nov 2021 00:01:28 -0600
Subject: [PATCH] Test that README urls are secure

---
 test/prebuild.js | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/test/prebuild.js b/test/prebuild.js
index 65c969d..ff3ade1 100644
--- a/test/prebuild.js
+++ b/test/prebuild.js
@@ -2,6 +2,7 @@ import fs from 'fs-extra'
 import test from 'ava'
 // import MarkdownIt from 'markdown-it'
 
+import { isValidHttpUrl } from '../helpers/check-types.js'
 import { buildReadmeAppList } from '../helpers/build-app-list.js'
 
 
@@ -12,11 +13,6 @@ require('dotenv').config()
 const allowedTitleCharacters = new Set( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz1234567890 -_.®/\()音乐体验版'.split('') )
 
 
-function isString( maybeString ) {
-    return (typeof maybeString === 'string' || maybeString instanceof String)
-}
-
-
 test.before(async t => {
     const readmeFileContent = await fs.readFile('./README.md', 'utf-8')
 
@@ -30,7 +26,7 @@ test.before(async t => {
     })
 })
 
-test('README App Titles are alphanumeric only', (t) => {
+test('README Apps are formated correctly', (t) => {
     // console.log('t.context.sitemapUrls', t.context.sitemapUrls)
 
     const {
@@ -44,6 +40,15 @@ test('README App Titles are alphanumeric only', (t) => {
     for (const readmeApp of readmeAppList) {
         const cleanedAppName = readmeApp.name//.toLowerCase()
 
+        // Check that all related links urls are valid
+        for (const relatedLink of readmeApp.relatedLinks) {
+            if ( !isValidHttpUrl( relatedLink.href ) ) {
+                t.log('relatedLink.href', readmeApp.name, relatedLink.href)
+
+                t.fail(`README App ${readmeApp.name} does not have valid url`, readmeApp.url)
+            }
+        }
+
         for ( const character of cleanedAppName ) {
             if ( !allowedTitleCharacters.has( character ) ) {