From d026a5420ba4f532f07bdbeb727ffa631f772520 Mon Sep 17 00:00:00 2001
From: ThatGuySam <sam@sam.lc>
Date: Sat, 4 Apr 2026 18:31:46 -0500
Subject: [PATCH] fix(scanner): rename plist parser module to avoid CI cycle
 false positive

Madge treated the local plist parser module name as a circular dependency during the Netlify build lane after the TypeScript refactor. Rename the local module to plist-parser so the internal file no longer collides with the external plist package name, while keeping parser behavior unchanged.

Constraint: Must restore the deploy gate without changing parser semantics
Rejected: Disable the circular-dependency check | would hide a useful guard instead of fixing the naming conflict that triggered it
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Avoid naming local modules after direct external package imports when the repo relies on static dependency graph tooling
Tested: pnpm run typecheck; pnpm exec vitest run test/scanner/plist.test.ts test/scanner/file-api.test.ts test/scanner/client.test.ts test/prebuild/load-sitemap-endpoints.test.ts; pnpm run test-prebuild
Not-tested: Full production deploy completion before push
---
 helpers/scanner/parsers/{plist.ts => plist-parser.ts} | 0
 helpers/scanner/scan.ts                               | 2 +-
 test/scanner/plist.test.ts                            | 2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)
 rename helpers/scanner/parsers/{plist.ts => plist-parser.ts} (100%)

diff --git a/helpers/scanner/parsers/plist.ts b/helpers/scanner/parsers/plist-parser.ts
similarity index 100%
rename from helpers/scanner/parsers/plist.ts
rename to helpers/scanner/parsers/plist-parser.ts
diff --git a/helpers/scanner/scan.ts b/helpers/scanner/scan.ts
index 6015c6b..f718bad 100644
--- a/helpers/scanner/scan.ts
+++ b/helpers/scanner/scan.ts
@@ -6,7 +6,7 @@ import * as FileApi from './file-api'
 import type { NodeFile } from './file-api'
 import { isNonEmptyString, isString } from '../check-types.js'
 import { extractMachoMeta } from './parsers/macho.js'
-import { parsePlistBuffer } from './parsers/plist'
+import { parsePlistBuffer } from './parsers/plist-parser'
 
 zip.configure({
     useWebWorkers: !import.meta.env.SSR
diff --git a/test/scanner/plist.test.ts b/test/scanner/plist.test.ts
index 529790c..9fe2f5e 100644
--- a/test/scanner/plist.test.ts
+++ b/test/scanner/plist.test.ts
@@ -10,7 +10,7 @@ import {
 import {
     parseFileSync,
     parsePlistBuffer
-} from '~/helpers/scanner/parsers/plist'
+} from '~/helpers/scanner/parsers/plist-parser'
 
 type ParsedPlist = Record<string, string>