From d39a2a1d6cf2fdcd1b76bcc13a2a507bb5c85feb Mon Sep 17 00:00:00 2001
From: ThatGuySam <sam@sam.lc>
Date: Mon, 6 Apr 2026 11:00:53 -0500
Subject: [PATCH] Bundle fallback data into SSR instead of reading repo-local
 files

The previous route fallback fix worked locally but still failed on production because the Netlify SSR runtime did not have repo-local JSON files available at the paths the helper searched.

Switch the fallback helper to raw-import the generated app, game, device, and YouTube JSON inputs so the SSR bundle carries the data it needs at runtime, independent of function working directory or file packaging quirks.

Constraint: Netlify SSR bundling does not reliably expose repo-local generated files as runtime-readable filesystem paths
Rejected: Rely on Netlify included_files for SSR bundle data | the generated SSR function archive still omitted the fallback files
Rejected: Fetch large fallback JSON over HTTP on each request | unnecessary network dependency for a server-side fallback path
Confidence: medium
Scope-risk: narrow
Reversibility: clean
Directive: Prefer bundler-native inclusion for SSR-only fallback data when runtime file availability is uncertain on Netlify
Tested: vitest ./test/prebuild/config-node.test.js ./test/prebuild/site-listings.test.js; pnpm run netlify-build
Not-tested: live production after redeploy
---
 helpers/site-listings.js | 34 ++++++++++++----------------------
 1 file changed, 12 insertions(+), 22 deletions(-)

diff --git a/helpers/site-listings.js b/helpers/site-listings.js
index 6ba4c90..cacca60 100644
--- a/helpers/site-listings.js
+++ b/helpers/site-listings.js
@@ -1,43 +1,33 @@
-import fs from 'fs-extra'
-import path from 'path'
-import { fileURLToPath } from 'url'
+import youtubeVideosText from '~/static/api/youtube-videos.json?raw'
+import appListText from '~/static/app-list.json?raw'
+import deviceListText from '~/static/device-list.json?raw'
+import gameListText from '~/static/game-list.json?raw'
 
 import {
     buildVideoListingFromFetchedVideo,
     makeVideoSlug
 } from '~/helpers/build-video-list.js'
-import { youtubeVideoPath } from '~/helpers/api/youtube/build.js'
-
-const currentModuleDirectory = path.dirname( fileURLToPath( import.meta.url ) )
-const appListPath = path.join( currentModuleDirectory, '../static/app-list.json' )
-const gameListPath = path.join( currentModuleDirectory, '../static/game-list.json' )
-const deviceListPath = path.join( currentModuleDirectory, '../static/device-list.json' )
 const trailingCommaPattern = /,\s*([\]}])/g
-
-function parseGeneratedJsonFile ( filePath ) {
-    const fileContents = fs.readFileSync( filePath, 'utf8' )
-
-    return JSON.parse( fileContents.replace( trailingCommaPattern, '$1' ) )
-}
+const parsedDeviceList = JSON.parse( deviceListText.replace( trailingCommaPattern, '$1' ) )
+const parsedAppList = JSON.parse( appListText.replace( trailingCommaPattern, '$1' ) )
+const parsedGameList = JSON.parse( gameListText.replace( trailingCommaPattern, '$1' ) )
+const parsedYoutubeVideos = JSON.parse( youtubeVideosText )
 
 export function getDeviceListingBySlug ( slug ) {
-    const deviceList = parseGeneratedJsonFile( deviceListPath )
-
-    return deviceList.find( device => device.slug === slug ) || null
+    return parsedDeviceList.find( device => device.slug === slug ) || null
 }
 
 function getAllVideoAppsList () {
     return [
-        ...parseGeneratedJsonFile( appListPath ),
-        ...parseGeneratedJsonFile( gameListPath )
+        ...parsedAppList,
+        ...parsedGameList
     ]
 }
 
 export async function getVideoListingBySlug ( slug ) {
-    const fetchedVideos = await fs.readJson( youtubeVideoPath )
     const allVideoAppsList = getAllVideoAppsList()
 
-    for ( const [ videoId, fetchedVideo ] of Object.entries( fetchedVideos ) ) {
+    for ( const [ videoId, fetchedVideo ] of Object.entries( parsedYoutubeVideos ) ) {
         if ( makeVideoSlug( fetchedVideo.title, videoId ) !== slug ) continue
 
         return await buildVideoListingFromFetchedVideo( fetchedVideo, videoId, allVideoAppsList )