From edcc260faad77cec823913bde8f796e04a7fab42 Mon Sep 17 00:00:00 2001 From: ThatGuySam Date: Sun, 15 Mar 2026 12:58:18 -0500 Subject: [PATCH] fix(ci): repair github node 24 workflows Install pnpm before enabling setup-node's pnpm cache in the Cloudflare deploy job, and make the Node 24 check workflow self-contained by providing the public build URLs directly. These fixes address the first GitHub-hosted failures that surfaced after the Node 24 migration push without changing the application runtime. --- .github/workflows/deploy-cloudflare-workers.yml | 12 ++++++------ .github/workflows/run-ava-tests.js.yml | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/deploy-cloudflare-workers.yml b/.github/workflows/deploy-cloudflare-workers.yml index 432ae7d..e8d44d0 100644 --- a/.github/workflows/deploy-cloudflare-workers.yml +++ b/.github/workflows/deploy-cloudflare-workers.yml @@ -16,17 +16,17 @@ jobs: - name: Checkout uses: actions/checkout@v6 - - name: Use Node.js 24 - uses: actions/setup-node@v6 - with: - node-version-file: .nvmrc - cache: pnpm - - name: Setup PNPM uses: pnpm/action-setup@v4 with: version: 10.12.1 run_install: false + + - name: Use Node.js 24 + uses: actions/setup-node@v6 + with: + node-version-file: .nvmrc + cache: pnpm - name: Write Wrangler configs run: | diff --git a/.github/workflows/run-ava-tests.js.yml b/.github/workflows/run-ava-tests.js.yml index e703cd6..062503a 100644 --- a/.github/workflows/run-ava-tests.js.yml +++ b/.github/workflows/run-ava-tests.js.yml @@ -12,6 +12,9 @@ jobs: build: runs-on: ubuntu-latest + env: + PUBLIC_URL: https://doesitarm.com + PUBLIC_API_DOMAIN: https://api.doesitarm.com strategy: matrix: @@ -30,9 +33,6 @@ jobs: with: node-version: ${{ matrix.node-version }} cache: pnpm - - run: | - touch .env - echo ${{ secrets.GH_ENV }} >> .env - run: pnpm install --frozen-lockfile - run: pnpm build - run: pnpm test