Commit graph

31 commits

Author SHA1 Message Date
ThatGuySam
d026a5420b fix(scanner): rename plist parser module to avoid CI cycle false positive
Some checks failed
Deploy to Cloudflare Workers with Wrangler / Deploy (push) Has been cancelled
Run Node 24 Checks / build (24.x) (push) Has been cancelled
Madge treated the local plist parser module name as a circular dependency during the Netlify build lane after the TypeScript refactor. Rename the local module to plist-parser so the internal file no longer collides with the external plist package name, while keeping parser behavior unchanged.

Constraint: Must restore the deploy gate without changing parser semantics
Rejected: Disable the circular-dependency check | would hide a useful guard instead of fixing the naming conflict that triggered it
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Avoid naming local modules after direct external package imports when the repo relies on static dependency graph tooling
Tested: pnpm run typecheck; pnpm exec vitest run test/scanner/plist.test.ts test/scanner/file-api.test.ts test/scanner/client.test.ts test/prebuild/load-sitemap-endpoints.test.ts; pnpm run test-prebuild
Not-tested: Full production deploy completion before push
2026-04-04 18:31:46 -05:00
ThatGuySam
cd41143f0d refactor(scanner): type plist and file-api helpers
Convert the scanner's plist parser and Node-style file shim to TypeScript and add small unit tests so common parser and file-reader failures are caught before we need to lean on Playwright or the higher-level scanner test.

Constraint: Must preserve current scanner behavior while tightening the lowest-level helper surface
Rejected: Jump straight to Mach-O parser conversion | harder to isolate regressions without first proving the smaller helper-test pattern
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Add small module-level regression tests for repeatable scanner breakage before expanding browser coverage
Tested: pnpm run typecheck; pnpm exec vitest run test/scanner/plist.test.ts test/scanner/file-api.test.ts test/scanner/client.test.ts; pnpm run test; pnpm run test:browser
Not-tested: Production deploy behavior prior to push
2026-04-04 18:13:32 -05:00
Sam Carlton
6de839a6d6 Make scan imports relative for Worker compat 2022-08-07 15:13:56 -05:00
Sam Carlton
e008ad7ddf Reenable MachoNode 2022-07-27 21:25:36 -05:00
Sam Carlton
3be1dd52a7 Try importing buffer index
# Conflicts:
#	helpers/scanner/client.mjs
2022-07-26 23:25:27 -05:00
Sam Carlton
3ee6a8c13e Remove big int import 2022-07-26 21:31:51 -05:00
Sam Carlton
df266d7760 Use native BigInt
# Conflicts:
#	helpers/scanner/parsers/plist.js
2022-07-26 21:28:44 -05:00
Sam Carlton
f717f4bf22 Import parseMacho normally 2022-07-22 00:07:35 -05:00
Sam Carlton
65692733f2 Try disabling MachoNode 2022-07-21 22:47:02 -05:00
Sam Carlton
07ee8760b5 Rebuild endian-reader as class 2022-07-21 22:42:26 -05:00
Sam Carlton
f499b3eecb Log parser start 2022-07-21 21:31:21 -05:00
Sam Carlton
62a5b430e1 Continue on parser fail 2022-07-21 21:31:14 -05:00
Sam Carlton
d7112ae322 FIx File proccessing for Browser and Node 2022-07-21 21:30:50 -05:00
Sam Carlton
7f9d891ab7 Import MachoManic Magics to determine bits 2022-07-21 21:17:45 -05:00
Sam Carlton
127c37c52e Use Buffer directly for macho parser 2022-07-21 20:28:14 -05:00
Sam Carlton
d17ec1c23b Import Buffer directly 2022-07-21 19:54:54 -05:00
Sam Carlton
e161af18cf Trim error messages 2022-07-19 22:27:49 -05:00
Sam Carlton
c04da29933 User local MachoNode 2022-07-19 22:27:37 -05:00
Sam Carlton
5bce0c5dc3 Move makeFileBuffer logic to function 2022-07-19 22:26:19 -05:00
Sam Carlton
15ddc6c4b8 Add MachoNode locally 2022-07-19 22:24:49 -05:00
Sam Carlton
f59ebd9056 Detect plain text plists 2022-07-19 00:01:05 -05:00
Sam Carlton
c498dc5b33 Add binary plist parser 2022-07-18 23:53:01 -05:00
Sam Carlton
572bf0ec57 Remove loggers 2022-07-18 21:38:22 -05:00
Sam Carlton
d909010d36 Add 7z commands reference 2022-07-18 21:25:28 -05:00
Sam Carlton
f98a3f7ae1 Add experimental 7z compressor 2022-07-18 21:23:21 -05:00
Sam Carlton
a2a9acfa42 Include error message 2022-07-18 19:33:41 -05:00
Sam Carlton
4c92f61fd5 Add timeout for Macho Parsers 2022-07-18 19:33:22 -05:00
Sam Carlton
ae3f9e9b64 Simplify macho parser error 2022-07-18 18:44:04 -05:00
Sam Carlton
3dfba1d355 Add MachoNode parser 2022-07-18 18:06:00 -05:00
Sam Carlton
a64f83b078 Fix typo 2022-07-18 18:05:44 -05:00
Sam Carlton
5146877f58 Enable using multiple macho parsers 2022-07-18 16:56:30 -05:00