mirror of
https://github.com/ThatGuySam/doesitarm.git
synced 2026-05-15 06:35:20 -07:00
fix(scanner): rename plist parser module to avoid CI cycle false positive
Madge treated the local plist parser module name as a circular dependency during the Netlify build lane after the TypeScript refactor. Rename the local module to plist-parser so the internal file no longer collides with the external plist package name, while keeping parser behavior unchanged. Constraint: Must restore the deploy gate without changing parser semantics Rejected: Disable the circular-dependency check | would hide a useful guard instead of fixing the naming conflict that triggered it Confidence: high Scope-risk: narrow Reversibility: clean Directive: Avoid naming local modules after direct external package imports when the repo relies on static dependency graph tooling Tested: pnpm run typecheck; pnpm exec vitest run test/scanner/plist.test.ts test/scanner/file-api.test.ts test/scanner/client.test.ts test/prebuild/load-sitemap-endpoints.test.ts; pnpm run test-prebuild Not-tested: Full production deploy completion before push
This commit is contained in:
parent
f1cb66c477
commit
d026a5420b
3 changed files with 2 additions and 2 deletions
|
|
@ -6,7 +6,7 @@ import * as FileApi from './file-api'
|
||||||
import type { NodeFile } from './file-api'
|
import type { NodeFile } from './file-api'
|
||||||
import { isNonEmptyString, isString } from '../check-types.js'
|
import { isNonEmptyString, isString } from '../check-types.js'
|
||||||
import { extractMachoMeta } from './parsers/macho.js'
|
import { extractMachoMeta } from './parsers/macho.js'
|
||||||
import { parsePlistBuffer } from './parsers/plist'
|
import { parsePlistBuffer } from './parsers/plist-parser'
|
||||||
|
|
||||||
zip.configure({
|
zip.configure({
|
||||||
useWebWorkers: !import.meta.env.SSR
|
useWebWorkers: !import.meta.env.SSR
|
||||||
|
|
|
||||||
|
|
@ -10,7 +10,7 @@ import {
|
||||||
import {
|
import {
|
||||||
parseFileSync,
|
parseFileSync,
|
||||||
parsePlistBuffer
|
parsePlistBuffer
|
||||||
} from '~/helpers/scanner/parsers/plist'
|
} from '~/helpers/scanner/parsers/plist-parser'
|
||||||
|
|
||||||
type ParsedPlist = Record<string, string>
|
type ParsedPlist = Record<string, string>
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue